[PATCH] ARM testcase improvements

[Matthias Braun]

Oh sorry, I was mislead by the manual: "With captured variables, CHECK-DAG: is able to match valid topological orderings of a DAG with edges from the definition of a variable to its use.” I really should have tried this first. Thanks Quentin.

I reverted the patch for now.

Greetings,
	Matthias


On Oct 11, 2013, at 11:10 AM, Renato Golin <renato.golin at linaro.org> wrote:

> On 11 October 2013 18:57, Quentin Colombet <qcolombet at apple.com> wrote:
> Apparently not!
> And in the case you want to check for the setting of lane in a register, this is useful (see my previous example).
> So either it is a bug in your check or a bug in FileCheck!
> 
> Oh dear! The manual had an example on this, which mislead me, but upon closer look, it uses either DAG line to define the variable and a non-DAG line to use it (so it's correct).
> 
> http://llvm.org/docs/CommandGuide/FileCheck.html
> 
> I think it should be ok to use the same pattern (non-DAG def -> DAG use / DAG def -> non-DAG use), since the order is strongly defined anyway.
> 
> Matthias, can you replace the patterns to follow the manual, pls?
> 
> cheers,
> --renato

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131011/cd270110/attachment.html>