[lld] r192422 - Return true from Resolver::resolve() on success.

Rui Ueyama ruiu at google.com
Thu Oct 10 23:16:33 PDT 2013


Author: ruiu
Date: Fri Oct 11 01:16:33 2013
New Revision: 192422

URL: http://llvm.org/viewvc/llvm-project?rev=192422&view=rev
Log:
Return true from Resolver::resolve() on success.

Modified:
    lld/trunk/lib/Core/Resolver.cpp
    lld/trunk/lib/Driver/Driver.cpp

Modified: lld/trunk/lib/Core/Resolver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Core/Resolver.cpp?rev=192422&r1=192421&r2=192422&view=diff
==============================================================================
--- lld/trunk/lib/Core/Resolver.cpp (original)
+++ lld/trunk/lib/Core/Resolver.cpp Fri Oct 11 01:16:33 2013
@@ -475,12 +475,12 @@ bool Resolver::resolve() {
   this->deadStripOptimize();
   if (this->checkUndefines(false)) {
     if (!_context.allowRemainingUndefines())
-      return true;
+      return false;
   }
   this->removeCoalescedAwayAtoms();
   this->linkTimeOptimize();
   this->_result.addAtoms(_atoms);
-  return false;
+  return true;
 }
 
 void Resolver::MergedFile::addAtom(const Atom& atom) {

Modified: lld/trunk/lib/Driver/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/Driver/Driver.cpp?rev=192422&r1=192421&r2=192422&view=diff
==============================================================================
--- lld/trunk/lib/Driver/Driver.cpp (original)
+++ lld/trunk/lib/Driver/Driver.cpp Fri Oct 11 01:16:33 2013
@@ -107,7 +107,7 @@ bool Driver::link(LinkingContext &contex
   // Do core linking.
   ScopedTask resolveTask(getDefaultDomain(), "Resolve");
   Resolver resolver(context);
-  if (resolver.resolve()) {
+  if (!resolver.resolve()) {
     if (!context.allowRemainingUndefines())
       return false;
   }





More information about the llvm-commits mailing list