[PATCH] Adding diversity for security

Andrei Homescu ahomescu at gmail.com
Thu Oct 10 16:02:24 PDT 2013



================
Comment at: lib/Target/X86/NOPInsertion.cpp:103
@@ +102,3 @@
+        MachineInstr *NewMI = NULL;
+        unsigned reg = nopRegs[NOPCode][!!is64Bit];
+        switch (NOPCode) {
----------------
Tom Roeder wrote:
> !! on bool is unnecessary
This is supposed to be a bool->int cast (false->0, true->1). I think I might have been getting compilation errors without it, have to check...


http://llvm-reviews.chandlerc.com/D1802



More information about the llvm-commits mailing list