[llvm] r192275 - Remove some old filters from the x86 disassembler table builder.

Chris Lattner clattner at apple.com
Wed Oct 9 22:15:24 PDT 2013


On Oct 9, 2013, at 11:15 AM, Craig Topper <craig.topper at gmail.com> wrote:

> It looks like there are some instructions that exist purely to trick the assembler parser into allowing either GR32 or GR64 to match GAS behavior. These instructions are then excluded in the disassembler since they have the same encodings. I can mark them AsmParserOnly in the td file to remove it from the disassembler, but it seems like we really should have the assembler generate the same internal instruction with either instruction. Is there a good way to do this or do I need to add custom checks to the parser itself?

It's been too long since I've looked at this.  Perhaps it makes sense to define a new operand that accepts either the 32-bit or the 64-bit spelling for the registers?

-Chris


> 
> 
> On Wed, Oct 9, 2013 at 10:08 AM, Chris Lattner <clattner at apple.com> wrote:
> 
> On Oct 8, 2013, at 10:28 PM, Craig Topper <craig.topper at gmail.com> wrote:
> 
> > I don't know yet if we can get rid of them completely, but I'm certainly going to try. If I can't, I think a bit in the td files is a good idea.
> 
> Makes sense, thanks for working on this!
> 
> -Chris
> 
> 
> 
> 
> -- 
> ~Craig

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20131009/76a38a9d/attachment.html>


More information about the llvm-commits mailing list