[PATCH] [Layout] Assign ordinals in resolution order

Shankar Easwaran shankare at codeaurora.org
Tue Oct 8 22:50:34 PDT 2013


On 10/9/2013 12:47 AM, Rui Ueyama wrote:
> On Tue, Oct 8, 2013 at 10:37 PM, Shankar Easwaran
> <shankare at codeaurora.org>wrote:
>
>> On 10/9/2013 12:31 AM, Rui Ueyama wrote:
>>
>>>     Really? Then how would you handle --{start,end}-group?
>>>
>> Its already handled in resetNextIndex. --start-group/--end-group works
>> with ELF already with my previous change!.
>>
> I added "assert(!nextFile->hasOrdinal());" at line Resolver.cpp:302, then
> many tests failed with the assertion error. Why?
It would indeed fail. because the file has not yet been assigned an ordinal.

Thanks

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation




More information about the llvm-commits mailing list