[PATCH] [Layout] Assign ordinals in resolution order

Rui Ueyama ruiu at google.com
Tue Oct 8 22:17:22 PDT 2013



================
Comment at: lib/Core/Resolver.cpp:302
@@ -299,1 +301,3 @@
+    if (nextFile->kind() == File::kindObject) {
+      nextFile->setOrdinal(_context.getNextOrdinalAndIncrement());
       handleFile(*nextFile);
----------------
Shankar Kalpathi Easwaran wrote:
> Rui Ueyama wrote:
> > Don't you need to check if an ordinal has already been assigned?
> no there is no need do that for files. If its an object file, the resolver shouldnt see the same file again.
I'd think there's no such guarantee. For example, for --{start,end}-group, resolver would see the files in a group multiple times, no?


http://llvm-reviews.chandlerc.com/D1865



More information about the llvm-commits mailing list