[PATCH] AArch64 Neon scalar saturating accumulated of unsigned value instructions

mcrosier at codeaurora.org mcrosier at codeaurora.org
Tue Oct 8 08:38:53 PDT 2013


> Hi Chad,
>
>
> +  def bb : NeonI_Scalar2SameMisc<u, 0b00, opcode,
> +                          (outs FPR8:$Rd), (ins FPR8:$Rn),
>
> I think there should be a second input operand for all of these, tied
> to the output. Otherwise what's being added? This affects the patterns
> and the tests (and Clang) too.

This patch is for scalar saturating accmulated of unsigned value
(SUQADD/USQADD).  According to the documentation I have it only has two
operands, one input and one output, but perhaps I'm missing something.

> A few tests in MC/Disassembler/AArch64 would be useful too. Not that I
> think they're wrong now, but just in case someone does some weird
> poking around in future.

Adding these now.  Thanks for catching this.

 Chad

> Cheers.
>
> Tim.
>





More information about the llvm-commits mailing list