[PATCH, test-suite] Update to RUNSAFELY

Daniel Dunbar daniel.dunbar at gmail.com
Mon Oct 7 21:38:26 PDT 2013


Sure, looks fine to me.

 - Daniel


On Oct 7, 2013, at 18:07, Doug Gilmore <Doug.Gilmore at imgtec.com> wrote:

> We found that specifying test-suite RUNUNDER make variable
> to be a program plus argument doesn't work.
>
> I attached a patch to fix this issue.
>
> Is it OK if we apply this change?
>
> Thanks,
>
> Doug
>
> Commit comment:
>
> Fix RUNSAFELY make variable definition.
>
> To allow the RUNUNDER script to be run with parameters, the
> the definition of RUNSAFELY needs to quote the interpolation
> of RUNUNDER.
>
> diff --git a/Makefile.programs b/Makefile.programs
> index ce38042..3662514 100644
> --- a/Makefile.programs
> +++ b/Makefile.programs
> @@ -111,7 +111,7 @@ RUNSAFELY := $(RUNSAFELY) -rp "$(REMOTE_PORT)"
> endif
>
> ifdef RUNUNDER
> -RUNSAFELY := $(RUNSAFELY) -u $(RUNUNDER)
> +RUNSAFELY := $(RUNSAFELY) -u "$(RUNUNDER)"
> ifdef EXECUTION_ENVIRONMENT_OVERRIDES
> $(error "cannot use both RUNUNDER and EXECUTION_ENVIRONMENT_OVERRIDES")
> endif



More information about the llvm-commits mailing list