[PATCH] Windows: Add support for unicode command lines
bigcheesegs at gmail.com
Sun Oct 6 14:14:56 PDT 2013
On Sun, Oct 6, 2013 at 11:47 AM, Reid Kleckner <rnk at google.com> wrote:
> On Sun, Oct 6, 2013 at 2:39 PM, Yunzhong Gao <
> Yunzhong_Gao at playstation.sony.com> wrote:
>> In lib/Support/Windows/Signals.inc,
>> + HMODULE hLib = ::LoadLibrary(TEXT("Dbghelp.dll"));
>> Will LoadLibrary accept unicode file names, or do you have to use
>> LoadLibraryW instead?
> LoadLibrary will be either A or W, and TEXT() will ensure it works either
> way, so this instance is fine. In general the rest of Support/Windows uses
> explicit *W routines.
We should always explicitly use W and never rely on TEXT and friends macros.
- Michael Spencer
>> ARCANIST PROJECT
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits