Suggesting elimination of unused Target implementation members

MathOnNapkins . mathonnapkins at
Sat Oct 5 13:24:16 PDT 2013

Dear All,

While researching the existing targets I noticed that
getEHExceptionRegister() and getEHHandlerRegister() are not called anywhere
in the source tree (presumably used to be defined in TargetRegisterInfo.h
as a pure virtual?) Several targets still implement and declare member
functions with these names, and only one of them (PowerPC) does anything
meaningful. So, unless they're being kept around for posterity or future
use, I would venture to say that they're just taking up space. I've
included a patch that removes them.

Thanks for reading,
~MoN / Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eliminate_eh_reg_cruft.patch
Type: application/octet-stream
Size: 6910 bytes
Desc: not available
URL: <>

More information about the llvm-commits mailing list