[PATCH][AsmParser][MC] Allow asm parser to emit elf header flags

Rafael EspĂ­ndola rafael.espindola at gmail.com
Fri Oct 4 15:35:33 PDT 2013


On 3 October 2013 19:59, Jack Carter <Jack.Carter at imgtec.com> wrote:
> I am pushing the new code through clang-format and implementing the suggestions.
>
> I am still perplexed on why change the dyn_cast to a cast. I still have the burn marks for when you guys had me make the MipsAsmPrinter variant use dyn_cast.
>

There are two possible situations
* dyn_cast can fail. We should have a test where that happens.
* It cannot. We should use cast instead.

Cheers,
Rafael



More information about the llvm-commits mailing list