[PATCH] Windows: Add support for unicode command lines

Rui Ueyama ruiu at google.com
Fri Oct 4 10:16:56 PDT 2013

Comment at: include/llvm/Support/Process.h:175
@@ +174,3 @@
+  /// for program execution.
+  static Optional<ArrayRef<const char *> >
+  GetArgumentVector(ArrayRef<const char *> OriginalMainArgs,
Reid Kleckner wrote:
> Rui Ueyama wrote:
> > In Unix this function does nothing and does not use any argument. In Windows the first argument (OriginalMainArgs) is ignored. It feels like they are really different, and they don't not necessarily have to have the same interface.
> > 
> > I'd probably rather make this a function defined only when LLVM_ON_WIN32 is defined, and guard the call of this function in LLVM's main() with LLVM_ON_WIN32.
> I'd rather avoid ifdefs in main.
I thought the same thing first, but found that we already have an #ifdef _WIN32 in main.


More information about the llvm-commits mailing list