[PATCH] Add address space arguments to MemoryBuiltins
nunoplopes at sapo.pt
Thu Oct 3 11:33:11 PDT 2013
The patch itself LGTM.
The test, however, doesn't look right. Doesn't it pass without the patch? You need a test case that really shows that the patch is working. E.g., two objectsize on pointers with different sizes, objectize returning an i32, when the pointer is only 8 bits (and vice-versa), etc. All those tricky edge cases.
More information about the llvm-commits