[PATCH] [ARM] Improve build attributes emission

Amara Emerson amara.emerson at arm.com
Thu Oct 3 07:37:19 PDT 2013

Comment at: lib/Target/ARM/ARMAsmPrinter.cpp:757
@@ +756,3 @@
+    return ARMBuildAttrs::v7;
+  else if (Subtarget->hasV6T2Ops())
+    return ARMBuildAttrs::v6T2;
Renato Golin wrote:
> Amara Emerson wrote:
> > Richard Barton wrote:
> > > It looks like this table will have to also take into account M-Profile to distinguish between v6-M and normal v6 architectures.
> > Agreed, I'll make this change.
> Isn't that covered by the Subtarget->isMClass() below?
Not quite, at the moment this change would emit arch=v6 and arch_profile=microcontroller. It should instead emit v6-M (or v6S-M).


More information about the llvm-commits mailing list