[PATCH] tsan: ignore interceptors coming from specified libraries

Alexander Potapenko glider at google.com
Thu Oct 3 06:22:28 PDT 2013

  LGTM with a nit

Comment at: sanitizer_common/sanitizer_libignore.h:66
@@ +65,3 @@
+  LibIgnore(const LibIgnore&);  // not implemented
+  void operator = (const LibIgnore&);  // not implemented
Dmitry Vyukov wrote:
> Alexander Potapenko wrote:
> > I suggest to remove the declarations of non-implemented functions.
> Then it will be possible to copy objects of this class, something that I want to prevent.
Got it now. I just think "not implemented" is a poor comment.
How about "disallow copying LibIgnore objects"?


More information about the llvm-commits mailing list