[PATCH] Support for microMIPS relocations 1/3

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Oct 1 10:51:09 PDT 2013

On 1 October 2013 13:39, Jack Carter <Jack.Carter at imgtec.com> wrote:
> This is testing the direct object emitter which shares some code with
> llvm-mc, but is a different tool and has different paths.
> The ideal tests for this would be to have 2 tests, one with llc and the
> other with llvm-mc.

Short of very rare cases the code path is the same. Why is there
different code paths in here? It is not obvious on the patch that
there are and even less obvious that there should be.

We should only have llc producing objects directly when we cannot test
a particular path with two independent tests (.ll to .s and .s to .o).
Those cases should be very clearly documented as to why they cannot be


More information about the llvm-commits mailing list