[llvm] r191343 - Move LTO support library to a component, allowing it to be tested

[Tom Roeder]

Great, thanks.

Could you or Peter commit this for me? I do not have commit access.

Thanks,

Tom

On Fri, Sep 27, 2013 at 5:16 PM, Rafael Espíndola
<rafael.espindola at gmail.com> wrote:
> LGTM
>
> On 27 September 2013 20:05, Tom Roeder <tmroeder at google.com> wrote:
>> On Fri, Sep 27, 2013 at 4:37 PM, Rafael Espíndola
>> <rafael.espindola at gmail.com> wrote:
>>> On 27 September 2013 19:22, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>>>> On 27 September 2013 16:37, Tom Roeder <tmroeder at google.com> wrote:
>>>>> Hi Richard,
>>>>>
>>>>> Thanks for catching that. The LTO library code was including
>>>>> llvm/CodeGen/CommandFlags.h, which was also getting included in
>>>>> binaries like llc, hence the multiple definitions.
>>>
>>> Reading the patch I think you meant copy and pasting, not #including.
>>>
>>> The patch is OK, but could you move the ExportedSymbols bits to a new patch?
>>>
>>> Cheers,
>>> Rafael
>>
>> Sorry for the confusion. Yes, that's right.
>>
>> Here's a patch that doesn't include the ExportedSymbols bit.
>>
>> Thanks,
>>
>> Tom