[PATCH] Implement aarch64 neon instruction class AdvSIMD (by element) - Clang

Jiangning Liu liujiangning1 at gmail.com
Sun Sep 29 20:28:53 PDT 2013


  Hi Tim,

  I removed all newly added xxx_LNQ enums.

  Thanks,
  -Jiangning


================
Comment at: utils/TableGen/NeonEmitter.cpp:1571-1572
@@ -1503,3 +1570,4 @@
     break;
   case OpMulLane:
+  case OpMulLaneQ:
     s += "__a * " + SplatLane(nElts, "__b", "__c") + ";";
----------------
Tim Northover wrote:
> Why are these distinct? As far as I can see they are treated in exactly the same way by TableGen. Or am I missing something not shown by a simple grep; some endsWith('Q') weirdness or something?
Yeah! Kevin also mentioned this problem to me. I uploaded a new version and removed all newly added xxx_LNQ enums.


http://llvm-reviews.chandlerc.com/D1752



More information about the llvm-commits mailing list