[PATCH] yaml2coff/elf: Touchup for compatibility.
silvas at purdue.edu
Fri Sep 27 14:06:13 PDT 2013
For the yaml2elf stuff, can you fix it by passing an ArrayRef? (it has an
implicit conversion from std::vector) I think that would be cleaner. (also
update vectorDataSize to use ArrayRef and rename the two functions to
writeArrayData and arrayDataSize).
-- Sean Silva
On Fri, Sep 27, 2013 at 5:00 PM, Will Dietz <wdietz2 at uiuc.edu> wrote:
> The ambiguity I'm encountering is between:
> std::string::append(size_t, char);
> template <class InputIterator> std::string::append(InputIterator
> first, InputIterator last) [with InputIterator=int]
> This patch makes it clear the '0' is a char and therefore should be
> using the first version.
> Does that make sense/sound good? :)
> On Fri, Sep 27, 2013 at 2:56 PM, Rafael Espíndola
> <rafael.espindola at gmail.com> wrote:
> > LGTM.
> > Just out of curiosity, what is the ambiguity that you are getting with
> > On 26 September 2013 18:01, Will Dietz <wdietz2 at uiuc.edu> wrote:
> >> See attached.
> >> Thanks!
> >> ~Will
> >> _______________________________________________
> >> llvm-commits mailing list
> >> llvm-commits at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the llvm-commits