[PATCH] Use getFirstNonPHI to set the insertion point for PHIs

Eli Friedman eli.friedman at gmail.com
Thu Sep 26 15:02:52 PDT 2013


On Thu, Sep 26, 2013 at 2:35 PM, Justin Bogner <mail at justinbogner.com>wrote:

> When creating new PHI instructions in SLPVectorizer and LoopVectorize,
> we're setting the insertion point using getFirstInsertionPt. This does
> the wrong thing when landingpads are present, since getFirstInsertionPt
> skips past these.
>
> The attached patch uses getFirstNonPHI instead, and adds a testcase that
> crashes without the patch and passes with. Can someone please commit?
>

The patch is missing a testcase for the LoopVectorize change.

(On a side note, you should request commit access; see
http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access .)

-Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130926/fe90f66b/attachment.html>


More information about the llvm-commits mailing list