Fix PR 17368: disable unnecessary vector multiplication distribution for square of add/sub on ARM

[Weiming Zhao]

Hi Tim,

Thanks for the comments. The original test case was just copied from the one
above it (@distribute2_commutative) . :D
Attached is a more clean test case

Thanks,
Weiming

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
The Linux Foundation

-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: Wednesday, September 25, 2013 1:18 PM
To: Weiming Zhao
Cc: llvm-commits
Subject: Re: Fix PR 17368: disable unnecessary vector multiplication
distribution for square of add/sub on ARM

> Please help to review the patch

The change itself looks almost trivially right, but that test seems
excessively complicated to me; it's really not obvious what the key point is
if it ever breaks.

Is there a reason why you can't define @no_distribute to take (<8 x
i8>, <8 x i8>) and return <8 x i8>?

Cheers.

Tim.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-PR-17368-disable-vector-multiplication-distribution-.patch
Type: application/octet-stream
Size: 2360 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130925/6b4cabc0/attachment.obj>