[PATCH] Don't localize globals that may serve as leak checker roots.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Sep 25 13:37:51 PDT 2013


>> I agree. Wouldn't it be better for clang to attach metadata to a
>> global variable to say it is a GC root? That way the optimization is
>> only disabled when using a sanitizer.
>
>
> Huh? Isn't it just as broken with valgrind's leak checker? If not, why isn't
> it?

I assume it is broken with valgrind, but the llvm language spec
doesn't say we cannot hide "leak check roots". That is why I think
this should be controllable from the FE with an attribute (I now
realize it cannot be metadata since we don't want it dropped).

Cheers,
Rafael



More information about the llvm-commits mailing list