[PATCH] Fixed compilation when git repository has multiple remotes.

Daniel Sanders Daniel.Sanders at imgtec.com
Mon Sep 23 03:02:30 PDT 2013


I committed a similar fix for this bug in r190778 ("Fix the build for git repositories with multiple remotes"). 

Ideally, we ought to combine the advantages of both our patches. Your patch will report the origin remote if it exists but will fail to report any remotes if origin is not found (e.g. if the user cloned using something like 'git clone -o foo ...'), whereas the fix I committed will always return the first remote in the list but doesn't prefer origin when it is available. If we combined our patches, so that your command was tried first and if it failed to produce any output it fell back onto my command then we should have covered all the possible cases.

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Konstantin Tokarev
> Sent: 22 September 2013 13:48
> To: llvm-commits
> Subject: [PATCH] Fixed compilation when git repository has multiple
> remotes.
> Please review attached patch.
> --
> Regards,
> Konstantin

More information about the llvm-commits mailing list