[llvm] r191128 - Initialize BSSSection explicitly in InitMachOMCObjectFileInfo() to appease msvc.

NAKAMURA Takumi geek4civic at gmail.com
Fri Sep 20 19:34:45 PDT 2013


Author: chapuni
Date: Fri Sep 20 21:34:45 2013
New Revision: 191128

URL: http://llvm.org/viewvc/llvm-project?rev=191128&view=rev
Log:
Initialize BSSSection explicitly in InitMachOMCObjectFileInfo() to appease msvc.

This can revert r191087.

Modified:
    llvm/trunk/lib/MC/MCObjectFileInfo.cpp
    llvm/trunk/test/CodeGen/ARM/coalesce-dbgvalue.ll
    llvm/trunk/test/DebugInfo/X86/dbg-subrange.ll
    llvm/trunk/test/DebugInfo/X86/stringpool.ll

Modified: llvm/trunk/lib/MC/MCObjectFileInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCObjectFileInfo.cpp?rev=191128&r1=191127&r2=191128&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCObjectFileInfo.cpp (original)
+++ llvm/trunk/lib/MC/MCObjectFileInfo.cpp Fri Sep 20 21:34:45 2013
@@ -39,6 +39,9 @@ void MCObjectFileInfo::InitMachOMCObject
     = Ctx->getMachOSection("__DATA", "__data", 0,
                            SectionKind::getDataRel());
 
+  // BSSSection might not be expected initialized on msvc.
+  BSSSection = 0;
+
   TLSDataSection // .tdata
     = Ctx->getMachOSection("__DATA", "__thread_data",
                            MCSectionMachO::S_THREAD_LOCAL_REGULAR,

Modified: llvm/trunk/test/CodeGen/ARM/coalesce-dbgvalue.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/coalesce-dbgvalue.ll?rev=191128&r1=191127&r2=191128&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/coalesce-dbgvalue.ll (original)
+++ llvm/trunk/test/CodeGen/ARM/coalesce-dbgvalue.ll Fri Sep 20 21:34:45 2013
@@ -6,9 +6,6 @@
 ; instruction which must be updated during
 ; ConnectedVNInfoEqClasses::Distribute().
 
-; FIXME: Investigating.
-; XFAIL: win32
-
 target datalayout = "e-p:32:32:32-i1:8:32-i8:8:32-i16:16:32-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:32:64-v128:32:128-a0:0:32-n32-S32"
 target triple = "thumbv7-apple-ios3.0.0"
 

Modified: llvm/trunk/test/DebugInfo/X86/dbg-subrange.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/dbg-subrange.ll?rev=191128&r1=191127&r2=191128&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/X86/dbg-subrange.ll (original)
+++ llvm/trunk/test/DebugInfo/X86/dbg-subrange.ll Fri Sep 20 21:34:45 2013
@@ -3,9 +3,6 @@
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
 target triple = "x86_64-apple-macosx10.7.2"
 
-; FIXME: Investigating.
-; XFAIL: win32
-
 @s = common global [4294967296 x i8] zeroinitializer, align 16
 ;CHECK: .long	4294967295
 

Modified: llvm/trunk/test/DebugInfo/X86/stringpool.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/X86/stringpool.ll?rev=191128&r1=191127&r2=191128&view=diff
==============================================================================
--- llvm/trunk/test/DebugInfo/X86/stringpool.ll (original)
+++ llvm/trunk/test/DebugInfo/X86/stringpool.ll Fri Sep 20 21:34:45 2013
@@ -1,9 +1,6 @@
 ; RUN: llc -mtriple=x86_64-unknown-linux-gnu < %s | FileCheck %s --check-prefix=LINUX
 ; RUN: llc -mtriple=x86_64-darwin < %s | FileCheck %s --check-prefix=DARWIN
 
-; FIXME: Investigating.
-; XFAIL: win32
-
 @yyyy = common global i32 0, align 4
 
 !llvm.dbg.cu = !{!0}





More information about the llvm-commits mailing list