[PATCH] Fix some more MCJIT PIC test XFAILs (for i386)

[Kaylor, Andrew]

Committed as r191111.

-----Original Message-----
From: Dimitry Andric [mailto:dimitry at andric.com] 
Sent: Friday, September 20, 2013 5:12 PM
To: Kaylor, Andrew
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Fix some more MCJIT PIC test XFAILs (for i386)

No, I don't have commit access.  It would be great if you could commit it.

-Dimitry

On Sep 20, 2013, at 23:44, "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:

> I don't think so.  Do you not have commit access?  If not, I can do it.
> 
> Thanks,
> Andy
> 
> -----Original Message-----
> From: Dimitry Andric [mailto:dimitry at andric.com]
> Sent: Friday, September 20, 2013 1:56 PM
> To: Kaylor, Andrew
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] Fix some more MCJIT PIC test XFAILs (for i386)
> 
> Hi,
> 
> Did somebody manage to commit this, in the mean time?
> 
> -Dimitry
> 
> On Sep 6, 2013, at 18:44, "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:
> 
>> This looks fine.
>> 
>> It would nice if we had some consistency in the use of triples since i686 and i386 are essentially synonymous.  Maybe lit could normalize the triple string before it checks the XFAIL conditions?
>> 
>> I'm not saying that you should do that now, Dimitry, just putting it out there for discussion.  For now, your fix is reasonable to commit.
>> 
>> -Andy
>> 
>> From: llvm-commits-bounces at cs.uiuc.edu 
>> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Dimitry Andric
>> Sent: Friday, September 06, 2013 3:52 AM
>> To: llvm-commits at cs.uiuc.edu
>> Subject: [PATCH] Fix some more MCJIT PIC test XFAILs (for i386)
>> 
>> Ping...
>> 
>> Lately, I consistently got these few MCJIT test failures while building for i386-unknown-freebsd10:
>> 
>> Failing Tests (4):
>>   LLVM :: ExecutionEngine/MCJIT/remote/test-global-init-nonzero-sm-pic.ll
>>   LLVM :: ExecutionEngine/MCJIT/remote/test-ptr-reloc-sm-pic.ll
>>   LLVM :: ExecutionEngine/MCJIT/test-global-init-nonzero-sm-pic.ll
>>   LLVM :: ExecutionEngine/MCJIT/test-ptr-reloc-sm-pic.ll
>> 
>> These were all of the form:
>> 
>> FAIL: LLVM :: 
>> ExecutionEngine/MCJIT/remote/test-global-init-nonzero-sm-pic.ll (38 
>> of
>> 71)
>> ******************** TEST 'LLVM :: 
>> ExecutionEngine/MCJIT/remote/test-global-init-nonzero-sm-pic.ll' 
>> FAILED ********************
>> Script:
>> --
>> /home/dim/obj/llvm-189593M-trunk-freebsd10-i386-aconf-rel-1/Release+A
>> s serts/bin/lli -use-mcjit -remote-mcjit -relocation-model=pic 
>> -code-model=small 
>> /share/dim/src/llvm/trunk/test/ExecutionEngine/MCJIT/remote/test-glob
>> a
>> l-init-nonzero-sm-pic.ll > /dev/null
>> --
>> Exit Code: 1
>> 
>> Command Output (stderr):
>> --
>> warning: remote mcjit does not support lazy compilation LLVM ERROR: 
>> Program used external function '_GLOBAL_OFFSET_TABLE_' which could not be resolved!
>> 
>> --
>> 
>> Similar to the other recent commits in this area, the 'i386' arch has to explicitly added to the XFAIL cases, as in the attached patch.
>> 
>> This patch also changes test/lit.cfg to match 'i386' in the target_triple setting when running with mcjit, and mangling -mcjit into the target triple, which seems to be the most logical thing to do.
>> 
>> -Dimitry
>> 
>> P.S.: Since you theoretically can also have 'i486', 'i586' etc as part of the target triple, maybe we should also add all of these, or just fold everything into 'x86'...
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>