[PATCH] Move LinkerInput to LinkingContext.

Rui Ueyama ruiu at google.com
Fri Sep 20 14:20:45 PDT 2013

As we talked on IRC, Shankar is going to do the refactoring as he proposed.
It would be done hopefully within a week. After the refactoring is done,
adding a new file during core linking would become as easy as calling
context->inputGraph()->addInputElement(). I'll wait for it.

On Fri, Sep 20, 2013 at 1:38 AM, Rui Ueyama <ruiu at google.com> wrote:

> I don't believe it's agreed to do that refactoring in the way as you
> proposed, but even if so, I don't really see the reason why this change
> would doing the refactoring *very* hard. You would have to edit the code
> modified by this patch, but that's usual in incremental development. We are
> focusing on different target platforms, and we should avoid blocking each
> other as possible.
> On Fri, Sep 20, 2013 at 12:48 AM, Shankar Kalpathi Easwaran <
> shankarke at gmail.com> wrote:
>>   as it was discussed previously on llvmdev the plan is to remove
>> inputfiles, linkerinput and merge it in filenode
>>   the resolver is going to traverse the inputgraph. this change will make
>> new filenodes to be added at will.
>>   your change would make the change that I plan to make very hard. it is
>> also not clean.
>> http://llvm-reviews.chandlerc.com/D1569
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130920/4b3de0a4/attachment.html>

More information about the llvm-commits mailing list