[compiler-rt] r191080 - [asan] nuke yet another async-signal-safety bug in UAR (oh, my)

Kostya Serebryany kcc at google.com
Fri Sep 20 02:16:21 PDT 2013


Author: kcc
Date: Fri Sep 20 04:16:21 2013
New Revision: 191080

URL: http://llvm.org/viewvc/llvm-project?rev=191080&view=rev
Log:
[asan] nuke yet another async-signal-safety bug in UAR (oh, my)

Modified:
    compiler-rt/trunk/lib/asan/asan_fake_stack.h
    compiler-rt/trunk/lib/asan/asan_thread.h

Modified: compiler-rt/trunk/lib/asan/asan_fake_stack.h
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_fake_stack.h?rev=191080&r1=191079&r2=191080&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/asan_fake_stack.h (original)
+++ compiler-rt/trunk/lib/asan/asan_fake_stack.h Fri Sep 20 04:16:21 2013
@@ -77,6 +77,7 @@ class FakeStack {
   }
 
   void Destroy() {
+    PoisonAll(0);
     UnmapOrDie(this, RequiredSize(stack_size_log_));
   }
 

Modified: compiler-rt/trunk/lib/asan/asan_thread.h
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_thread.h?rev=191080&r1=191079&r2=191080&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/asan_thread.h (original)
+++ compiler-rt/trunk/lib/asan/asan_thread.h Fri Sep 20 04:16:21 2013
@@ -77,7 +77,6 @@ class AsanThread {
 
   void DeleteFakeStack() {
     if (!fake_stack_) return;
-    fake_stack_->PoisonAll(0);
     FakeStack *t = fake_stack_;
     fake_stack_ = 0;
     SetTLSFakeStack(0);





More information about the llvm-commits mailing list