[llvm] r191018 - Fix a typo and simplify a boolean expression.

David Blaikie dblaikie at gmail.com
Thu Sep 19 10:27:48 PDT 2013


Author: dblaikie
Date: Thu Sep 19 12:27:48 2013
New Revision: 191018

URL: http://llvm.org/viewvc/llvm-project?rev=191018&view=rev
Log:
Fix a typo and simplify a boolean expression.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=191018&r1=191017&r2=191018&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Thu Sep 19 12:27:48 2013
@@ -2337,8 +2337,7 @@ static uint8_t computeIndexValue(Compile
 
   // Compute the Attributes for the Die.
   uint32_t Value = dwarf::GDB_INDEX_SYMBOL_KIND_NONE;
-  bool External =
-      Die->findAttribute(dwarf::DW_AT_external) != NULL ? true : false;
+  bool External = Die->findAttribute(dwarf::DW_AT_external);
 
   switch (Die->getTag()) {
   case dwarf::DW_TAG_class_type:
@@ -2371,7 +2370,7 @@ static uint8_t computeIndexValue(Compile
     break;
   }
   // We don't need to add the CU into the bitmask for two reasons:
-  // a) the pubnames/pubtypes sections are per-cpu, and
+  // a) the pubnames/pubtypes sections are per-cu, and
   // b) the linker wouldn't understand it anyhow.
   // so go ahead and make it 1 byte by shifting it down.
   return Value >> dwarf::GDB_INDEX_CU_BITSIZE;





More information about the llvm-commits mailing list