[PATCH] Under MSVC, supresss warning 4224 and undefine NDEBUG for all release targets

Yaron Keren yaron.keren at gmail.com
Wed Sep 18 14:45:44 PDT 2013

Visual C++ 2012 produces warning 4224 nonstandard extension used : formal
parameter 'type' was previously defined as a type.

While patching HandleLLVMOptions, I noticed that NDBEUG is removed only
from the release compile flags but not from the minimum size release or the
release with debug info.
With these targets Visual C++ warns about NDEBUG being defined and

The attached patch addresses both issues.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130919/2b2beb0f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MSVC-HandleLLVMOptions-w4224-NDEBUG.diff
Type: application/octet-stream
Size: 1541 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130919/2b2beb0f/attachment.obj>

More information about the llvm-commits mailing list