[PATCH] Add error checking to reject neon_vector_type attribute on targets without NEON

Artyom Skrobov Artyom.Skrobov at arm.com
Thu Sep 12 09:17:00 PDT 2013


Hello,

We have discovered that test/Sema/neon-vector-types.c did not specify a target, therefore testing the NEON-related attributes on the host platform (which, in many cases, wouldn't even be ARM!)

In addition to correcting this oversight in the test, we're adding a check that the NEON-related attributes aren't used on a target without NEON.

We're also removing the sophisticated string parsing from ARMTargetInfo::hasFeature, on the grounds that it's 1) broken in cases when target CPU name is not specified explicitly; 2) outdated by disregarding ARMv8; 3) clearly in the wrong place -- analysing target CPU capabilities belongs in ARMTargetInfo initialisation, but needs not re-run every time a NEON-related feature is used.


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2548782
-------------- next part --------------
A non-text attachment was scrubbed...
Name: neon_attributes.patch
Type: application/octet-stream
Size: 9754 bytes
Desc: neon_attributes.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130912/3bcd63ce/attachment.obj>


More information about the llvm-commits mailing list