[PATCH] Fix the build for git repositories with multiple remotes.

Daniel Sanders Daniel.Sanders at imgtec.com
Thu Sep 12 07:18:45 PDT 2013


It seems that llvm-commits didn't receive an email. Presumably this is because it wasn't CC'd during the 'arc diff' command and the CC was added from the web interface.

-----Original Message-----
From: Daniel Sanders [mailto:daniel.sanders at imgtec.com] 
Sent: 12 September 2013 14:41
To: Daniel Sanders
Subject: [PATCH] Fix the build for git repositories with multiple remotes.

When a git repository had multiple remotes, ${repository} will be set to a multiline string. This causes compilation errors in SVNVersion.inc.

Fix this by replace CRLF and LF in ${repository} with a single space.

http://llvm-reviews.chandlerc.com/D1659

Files:
  cmake/modules/GetSVN.cmake

Index: cmake/modules/GetSVN.cmake
===================================================================
--- cmake/modules/GetSVN.cmake
+++ cmake/modules/GetSVN.cmake
@@ -24,6 +24,7 @@
     OUTPUT_VARIABLE repository
     OUTPUT_STRIP_TRAILING_WHITESPACE)
   string(STRIP "${repository}" repository)
+  string(REGEX REPLACE "(\r?\n)" " " repository "${repository}")
   file(APPEND "${HEADER_FILE}.txt"
     "#define ${name}_REVISION \"${revision}\"\n")
   file(APPEND "${HEADER_FILE}.txt"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D1659.1.patch
Type: text/x-patch
Size: 486 bytes
Desc: D1659.1.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130912/46b0dbbb/attachment.bin>


More information about the llvm-commits mailing list