[llvm] r190448 - Fix unused variables.

Eli Friedman eli.friedman at gmail.com
Tue Sep 10 17:44:01 PDT 2013


On Tue, Sep 10, 2013 at 5:32 PM, Richard Smith <richard at metafoo.co.uk>wrote:

> On Tue, Sep 10, 2013 at 4:18 PM, Eli Friedman <eli.friedman at gmail.com>wrote:
>
>> Author: efriedma
>> Date: Tue Sep 10 18:18:14 2013
>> New Revision: 190448
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=190448&view=rev
>> Log:
>> Fix unused variables.
>>
>> Modified:
>>     llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp
>>     llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp
>>     llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp
>>     llvm/trunk/lib/Target/Hexagon/HexagonMachineScheduler.cpp
>>     llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
>>
>> Modified: llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp?rev=190448&r1=190447&r2=190448&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp Tue Sep 10 18:18:14 2013
>> @@ -120,7 +120,9 @@ class RAGreedy : public MachineFunctionP
>>      RS_Done
>>    };
>>
>> +#ifndef NDEBUG
>>    static const char *const StageName[];
>> +#endif
>>
>>    // RegInfo - Keep additional information about each live range.
>>    struct RegInfo {
>>
>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp?rev=190448&r1=190447&r2=190448&view=diff
>>
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp
>> (original)
>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp Tue Sep
>> 10 18:18:14 2013
>> @@ -389,7 +389,6 @@ signed ResourcePriorityQueue::regPressur
>>  // Constants used to denote relative importance of
>>  // heuristic components for cost computation.
>>  static const unsigned PriorityOne = 200;
>> -static const unsigned PriorityTwo = 100;
>>  static const unsigned PriorityThree = 50;
>>  static const unsigned PriorityFour = 15;
>>  static const unsigned PriorityFive = 5;
>>
>
> The resulting code here looks a bit weird, due to the discontiguous
> priorities. Can we rename these or something?
>

r190466

-Eli
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130910/ae187a5f/attachment.html>


More information about the llvm-commits mailing list