[llvm] r190448 - Fix unused variables.

Richard Smith richard at metafoo.co.uk
Tue Sep 10 17:32:22 PDT 2013


On Tue, Sep 10, 2013 at 4:18 PM, Eli Friedman <eli.friedman at gmail.com>wrote:

> Author: efriedma
> Date: Tue Sep 10 18:18:14 2013
> New Revision: 190448
>
> URL: http://llvm.org/viewvc/llvm-project?rev=190448&view=rev
> Log:
> Fix unused variables.
>
> Modified:
>     llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp
>     llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp
>     llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp
>     llvm/trunk/lib/Target/Hexagon/HexagonMachineScheduler.cpp
>     llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
>
> Modified: llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp?rev=190448&r1=190447&r2=190448&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp (original)
> +++ llvm/trunk/lib/CodeGen/RegAllocGreedy.cpp Tue Sep 10 18:18:14 2013
> @@ -120,7 +120,9 @@ class RAGreedy : public MachineFunctionP
>      RS_Done
>    };
>
> +#ifndef NDEBUG
>    static const char *const StageName[];
> +#endif
>
>    // RegInfo - Keep additional information about each live range.
>    struct RegInfo {
>
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp?rev=190448&r1=190447&r2=190448&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp
> (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/ResourcePriorityQueue.cpp Tue Sep
> 10 18:18:14 2013
> @@ -389,7 +389,6 @@ signed ResourcePriorityQueue::regPressur
>  // Constants used to denote relative importance of
>  // heuristic components for cost computation.
>  static const unsigned PriorityOne = 200;
> -static const unsigned PriorityTwo = 100;
>  static const unsigned PriorityThree = 50;
>  static const unsigned PriorityFour = 15;
>  static const unsigned PriorityFive = 5;
>

The resulting code here looks a bit weird, due to the discontiguous
priorities. Can we rename these or something?

Modified: llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp?rev=190448&r1=190447&r2=190448&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/Hexagon/HexagonISelLowering.cpp Tue Sep 10
> 18:18:14 2013
> @@ -39,8 +39,6 @@
>
>  using namespace llvm;
>
> -const unsigned Hexagon_MAX_RET_SIZE = 64;
> -
>  static cl::opt<bool>
>  EmitJumpTables("hexagon-emit-jump-tables", cl::init(true), cl::Hidden,
>                 cl::desc("Control jump table emission on Hexagon target"));
>
> Modified: llvm/trunk/lib/Target/Hexagon/HexagonMachineScheduler.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Hexagon/HexagonMachineScheduler.cpp?rev=190448&r1=190447&r2=190448&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/Hexagon/HexagonMachineScheduler.cpp (original)
> +++ llvm/trunk/lib/Target/Hexagon/HexagonMachineScheduler.cpp Tue Sep 10
> 18:18:14 2013
> @@ -457,9 +457,7 @@ static SUnit *getSingleUnscheduledSucc(S
>  // Constants used to denote relative importance of
>  // heuristic components for cost computation.
>  static const unsigned PriorityOne = 200;
> -static const unsigned PriorityTwo = 100;
>  static const unsigned PriorityThree = 50;
> -static const unsigned PriorityFour = 20;
>  static const unsigned ScaleTwo = 10;
>  static const unsigned FactorOne = 2;


Here too.

Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=190448&r1=190447&r2=190448&view=diff
>
> ==============================================================================
> --- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Tue Sep 10 18:18:14
> 2013
> @@ -2224,8 +2224,6 @@ static bool CC_MipsO32_FP64(unsigned Val
>  //                  Call Calling Convention Implementation
>
>  //===----------------------------------------------------------------------===//
>
> -static const unsigned O32IntRegsSize = 4;
> -
>  // Return next O32 integer argument register.
>  static unsigned getNextIntArgReg(unsigned Reg) {
>    assert((Reg == Mips::A0) || (Reg == Mips::A2));
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130910/32273ccb/attachment.html>


More information about the llvm-commits mailing list