[PATCH] Make variable argument intrinsics behave correctly in a Win64 CC function.

Charles Davis cdavis5x at gmail.com
Mon Sep 9 18:39:15 PDT 2013



================
Comment at: lib/Transforms/Instrumentation/MemorySanitizer.cpp:1924
@@ -1923,1 +1923,3 @@
   void visitVAStartInst(VAStartInst &I) {
+    if (I.getParent()->getParent()->getCallingConv() ==
+        CallingConv::X86_64_Win64)
----------------
Evgeniy Stepanov wrote:
> I'd prefer if this was done in CreateVarArgHelper() by selecting VarArgNoOpHelper for Win64.
> 
Done. (I didn't do this for Win64 targets, only for functions with the Win64 CC.)


http://llvm-reviews.chandlerc.com/D1622



More information about the llvm-commits mailing list