[llvm] r190304 - Silencing a warning about control flow reaching the end of a non-void function.

[Duncan Sands]

Hi Aaron,

On 09/09/13 15:22, Aaron Ballman wrote:
> Author: aaronballman
> Date: Mon Sep  9 08:22:45 2013
> New Revision: 190304
>
> URL: http://llvm.org/viewvc/llvm-project?rev=190304&view=rev
> Log:
> Silencing a warning about control flow reaching the end of a non-void function.
>
> Modified:
>      llvm/trunk/lib/Target/XCore/XCoreLowerThreadLocal.cpp
>
> Modified: llvm/trunk/lib/Target/XCore/XCoreLowerThreadLocal.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/XCore/XCoreLowerThreadLocal.cpp?rev=190304&r1=190303&r2=190304&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/XCore/XCoreLowerThreadLocal.cpp (original)
> +++ llvm/trunk/lib/Target/XCore/XCoreLowerThreadLocal.cpp Mon Sep  9 08:22:45 2013
> @@ -122,6 +122,7 @@ createReplacementInstr(ConstantExpr *CE,
>       default:
>         assert(0 && "Unhandled constant expression!\n");
>     }
> +  llvm_unreachable("Unhandled constant expression!\n");

how about removing the default case, since it isn't doing anything
useful any more.

Ciao, Duncan.

>   }
>
>   static bool replaceConstantExprOp(ConstantExpr *CE) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>