[Patch] GVN fold conditional-branch on-the-fly

Daniel Berlin dberlin at dberlin.org
Sun Sep 8 00:25:01 PDT 2013


On Sat, Sep 7, 2013 at 11:45 PM, Shuxin Yang <shuxin.llvm at gmail.com> wrote:
> Alright, I remember a case where GVN LDPRE miss. It nothing about "partial
> downsafty" thing.

There are plenty of cases it misses.
We'll agree to disagree over whether it will catch the cases i'm
talking about, or whether it catches all the normal PRE cases, as was
your original claim.
I believe I even told Owen not to bother with doing that when he implemented it.

> Anyway, there is no need to discuss this issue in this list anymore.
Okay.

>
> I would say Owen did great job in implementing this GVN in 2.6k LOC. The
> code can speak.
> It only took me one afternoon to reverse engineering this piece of code
> without his help.
> It is not complicated at all.



More information about the llvm-commits mailing list