[PATCH] Refactor parseFile API to use LinkerInput directly

[Shankar Easwaran]

I dont agree here.

There are two disadvantages of associating using a FileNode as the parameter

a) It defeats the purpose of using lld as an API, say the user just 
wants to use only the Reader, the user would need to create a 
FileNode/LinkerInput than passing a memory buffer directly.

b) Your comment FileNodes are associated with the inputGraph, doesnot 
make things proper, because FileNodes/ControlNodes are associated only 
with input arguments as it appeared in the input graph.

For example: When ReaderArchive tries to pull in a archive member 
satisfying an undefined reference,  I dont want to create a FileNode here.

Thanks

Shankar Easwaran

On 9/6/2013 12:59 PM, Joerg Sonnenberger wrote:
>    That doesn't make sense. If anything, the argument will change from LinkerInput to FileNode. At the same time, I still don't believe that merging them is necessarily a good idea, but I don't want to focus on that part while having such a large diff pending.
>
> http://llvm-reviews.chandlerc.com/D1598
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation