[PATCH 0/5] LiveInterval refactoring

[Andrew Trick]

On Sep 3, 2013, at 6:28 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:

> LGTM

Yes. It’s an impressive amount of work and looks great.
-Andy

> On Sep 3, 2013, at 5:15 PM, Matthias Braun <mbraun at apple.com> wrote:
> 
>> 
>> On Sep 3, 2013, at 3:11 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>> 
>>> 
>>> On Sep 3, 2013, at 2:41 PM, Matthias Braun <mbraun at apple.com> wrote:
>>>> Attached is a patch for the LiveRange -> LiveInterval::Segment renaming. I’m starting the rebasing of my other patches now.
>>> 
>>> Looks good.
>>> 
>>>> If we are renaming anyway, I would propose to rename LiveInterval to RegLiveRange (or RegisterLiveRange), which is more logical as it will become a subclass of LiveRange with just a register number and spill weight added.
>>> 
>>> Maybe you should wait until you know all the classes you want in the new design?
>> 
>>> 
>>> Also remember that LiveInterval is currently used for stack slots as well.
>> Ok, I’ll wait with that :) Yes, well I guess I’ll wait until I know better whether I want subregister liveness for the stackslots as well.
>> 
>> Anyway here is the updated complete patchset.
>> 
>> Greetings,
>>   Matthias
>> <0001-rename-LiveRange-to-LiveInterval-Segment.patch>
>> <0002-refactor-LiveInterval-introduce-new-LiveRange-class.patch>
>> <0003-Pass-LiveQueryResult-by-value.patch>
>> <0004-change-MachineVerifier-to-work-on-LiveRange-LiveInte.patch>
>> <0005-work-on-LiveRange-instead-of-LiveInterval-where-poss.patch>
>> <0006-Represent-RegUnit-liveness-with-LiveRange-instance.patch>
>> <0007-print-register-in-LiveInterval-print.patch>
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits