[patch] First step to fix pr11866 during LTO

Nick Kledzik kledzik at apple.com
Thu Sep 5 13:04:34 PDT 2013


Rafael,

When would the linker call this new lto_codegen_add_symtab_symbol() function?  What is the semantic difference between it and lto_codegen_add_must_preserve_symbol()?

-Nick

On Sep 5, 2013, at 12:49 PM, Bill Wendling <wendling at apple.com> wrote:
> On Sep 5, 2013, at 11:51 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
> 
>>> Ah! Okay, I see what you mean. Thanks for the explanation. :-)
>> 
>> Any thoughts on the patch itself?
>> 
> The patch looks fine to me. Though it might be worthwhile explaining the difference between the symtab and external name in one of the comments. I'm CC'ing Nick to see if this is something that ld64 should use.
> 
> -bw





More information about the llvm-commits mailing list