[PATCH] EABI Divmod Legal

Amaury de la Vieuville amaury.dlv at gmail.com
Thu Sep 5 09:44:32 PDT 2013


  Hi Renato,


================
Comment at: test/CodeGen/ARM/divmod-eabi.ll:109
@@ -108,1 +108,3 @@
+; EABI: mov [[div2:r[0-9]+]], r1
+; EABI: __aeabi_ldivmod
 ; GNU: __aeabi_ldivmod
----------------
I think the part checking the remainder registers is missing here.

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:1935
@@ -1922,1 +1934,3 @@
+  }
+
   TargetLowering::
----------------
If you leave it this way, you probably need to add all this to the SDNode* overload of ExpandLibCall as well (right above).

================
Comment at: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp:3380
@@ -3332,1 +3379,3 @@
+      Tmp1 = ExpandLibCall(LC, VT, Args, 2, isSigned, dl);
+    }
     Results.push_back(Tmp1);
----------------
Do you still need this? Isn't ExpandIntLibcall able to handle this now?


http://llvm-reviews.chandlerc.com/D1575



More information about the llvm-commits mailing list