[compiler-rt] r189821 - [asan] Hopefully un-break the RTL on Windows

Alexey Samsonov samsonov at google.com
Wed Sep 4 01:04:56 PDT 2013


On Tue, Sep 3, 2013 at 10:33 PM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

>
>
>
> 2013/9/3 Reid Kleckner <rnk at google.com>
>
>> Can you use _searchenv here?
>> http://msdn.microsoft.com/en-us/library/w9a6wh7y(v=vs.90).aspx
>>
>
> It's rather "[why] do we need it at all?"
>
> Alexey, am I right this is only used in the symbolizer?
>

Yes.


> Can we just disable it on Windows?
>

Yes.


>
>
>> On Tue, Sep 3, 2013 at 8:50 AM, Timur Iskhodzhanov <timurrrr at google.com>wrote:
>>
>>> Author: timurrrr
>>> Date: Tue Sep  3 10:50:13 2013
>>> New Revision: 189821
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=189821&view=rev
>>> Log:
>>> [asan] Hopefully un-break the RTL on Windows
>>>
>>> Modified:
>>>     compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc
>>>
>>> Modified: compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc?rev=189821&r1=189820&r2=189821&view=diff
>>>
>>> ==============================================================================
>>> --- compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc (original)
>>> +++ compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc Tue Sep  3
>>> 10:50:13 2013
>>> @@ -197,7 +197,8 @@ void SetStackSizeLimitInBytes(uptr limit
>>>  }
>>>
>>>  char *FindPathToBinary(const char *name) {
>>> -  UNIMPLEMENTED();
>>> +  // Nothing here for now.
>>> +  return 0;
>>>  }
>>>
>>>  void SleepForSeconds(int seconds) {
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>


-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130904/7ad006c3/attachment.html>


More information about the llvm-commits mailing list