[debuginfo-tests] r189915 - XFAILed the static-member.cpp test since we no longer support emitting debug info that support what Eric calls "the member hack".

[Michael Gottesman]

I think we can do one better. We can probably put something in LIT to detect the version of GDB and if we have that version of gdb/darwin we XFAIL it or something like that.

Michael

On Sep 3, 2013, at 10:06 PM, Eric Christopher <echristo at gmail.com> wrote:

> The member hack was this:
> 
> // In compatibility mode with older gdbs we put the linkage name on both
> // the TAG_variable DIE and on the TAG_member DIE.
> 
> and without it there was a bug in that gdb to where it couldn't
> find/resolve the member.
> 
> I'd like to keep the test and only xfail it on darwin since it should
> pass with a modern gdb. Ideally, I think, for darwin the test harness
> should be modified to run lldb and the tests updated to deal with any
> differences.
> 
> -eric
> 
> 
> On Tue, Sep 3, 2013 at 10:01 PM, David Blaikie <dblaikie at gmail.com> wrote:
>> Eric - mind adding some more detail on what this 'member hack' is?
>> 
>> and/or should we just delete these tests?
>> 
>> 
>> On Tue, Sep 3, 2013 at 9:44 PM, Michael Gottesman <mgottesman at apple.com>
>> wrote:
>>> 
>>> Author: mgottesman
>>> Date: Tue Sep  3 23:44:05 2013
>>> New Revision: 189915
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=189915&view=rev
>>> Log:
>>> XFAILed the static-member.cpp test since we no longer support emitting
>>> debug info that support what Eric calls "the member hack".
>>> 
>>> Modified:
>>>    debuginfo-tests/trunk/static-member.cpp
>>> 
>>> Modified: debuginfo-tests/trunk/static-member.cpp
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/static-member.cpp?rev=189915&r1=189914&r2=189915&view=diff
>>> 
>>> ==============================================================================
>>> --- debuginfo-tests/trunk/static-member.cpp (original)
>>> +++ debuginfo-tests/trunk/static-member.cpp Tue Sep  3 23:44:05 2013
>>> @@ -1,6 +1,7 @@
>>> // RUN: %clangxx -O0 -g %s -o %t -c
>>> // RUN: %clangxx %t -o %t.out
>>> // RUN: %test_debuginfo %s %t.out
>>> +// XFAIL: *
>>> 
>>> // DEBUGGER: delete breakpoints
>>> // DEBUGGER: break static-member.cpp:33
>>> 
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>>