[llvm] r189824 - Migrate the DWARF_VERSION constant to 4. It largely needs to go away.

[Eric Christopher]

On Tue, Sep 3, 2013 at 3:53 PM, Eric Christopher <echristo at gmail.com> wrote:
> On Tue, Sep 3, 2013 at 3:49 PM, Bob Wilson <bob.wilson at apple.com> wrote:
>>
>> On Sep 3, 2013, at 3:47 PM, Eric Christopher <echristo at gmail.com> wrote:
>>
>>> I can, sure. It looked like there was code setting things to dwarf2 by
>>> default via the front end. Trivial testcase or something more
>>> complicated?
>>
>> No, I don't have a test case.
>>
>
> Ah, I was wondering if something simple thrown into an executable would work.
>

OK, I've done something here:

M lib/CodeGen/AsmPrinter/DwarfDebug.cpp
Committed r189902

that should work in the case where you don't have a value coming
across from clang via the module. I'm not sure what else could be the
problem, but I can duplicate that ld64 has a problem with parsing
compile units with a dwarf version > 3.

Let me know?

-eric

>> FWIW, we are working to get all of our tools to support dwarf 4 but it's going to take a little while.
>>
>
> Awesome :)
>
> -eric
>
>>>
>>> -eric
>>>
>>> On Tue, Sep 3, 2013 at 3:45 PM, Bob Wilson <bob.wilson at apple.com> wrote:
>>>> This is breaking lots of things on Darwin.  Our linker cannot handle dwarf4 yet.  Can you #ifdef this for __APPLE__ for now?  Or just revert?
>>>>
>>>> On Sep 3, 2013, at 9:11 AM, Eric Christopher <echristo at gmail.com> wrote:
>>>>
>>>>> Author: echristo
>>>>> Date: Tue Sep  3 11:11:13 2013
>>>>> New Revision: 189824
>>>>>
>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=189824&view=rev
>>>>> Log:
>>>>> Migrate the DWARF_VERSION constant to 4. It largely needs to go away.
>>>>>
>>>>> Modified:
>>>>>   llvm/trunk/include/llvm/Support/Dwarf.h
>>>>>
>>>>> Modified: llvm/trunk/include/llvm/Support/Dwarf.h
>>>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Dwarf.h?rev=189824&r1=189823&r2=189824&view=diff
>>>>> ==============================================================================
>>>>> --- llvm/trunk/include/llvm/Support/Dwarf.h (original)
>>>>> +++ llvm/trunk/include/llvm/Support/Dwarf.h Tue Sep  3 11:11:13 2013
>>>>> @@ -69,7 +69,7 @@ const uint64_t DW64_CIE_ID = UINT64_MAX;
>>>>>
>>>>>
>>>>> enum dwarf_constants {
>>>>> -  DWARF_VERSION = 2,
>>>>> +  DWARF_VERSION = 4,
>>>>>
>>>>>  // Tags
>>>>>  DW_TAG_array_type = 0x01,
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> llvm-commits mailing list
>>>>> llvm-commits at cs.uiuc.edu
>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>
>>