[llvm] r188297 - Output DW_AT_stmt_list dwarf debug info as DW_FORM_sec_offset instead of DW_FORM_data4 as it is a section offset (fixes the coff/dwarf debug info statement locations)

[Eric Christopher]

On Tue, Sep 3, 2013 at 12:09 PM, Renato Golin <renato.golin at linaro.org> wrote:
> On 3 September 2013 19:43, Eric Christopher <echristo at gmail.com> wrote:
>>
>> But I don't think it's worth breaking windows debugging just for this.
>
>
> I didn't know there was a build failure because of this.

Yeah.

>
>
>> That said, for this particular one the patch to specify form based on
>> dwarf version should be straightforward. I'll happily review that.
>
>
> I don't want to introduce ad-hoc conditionals for specific Dwarf versions.
> I'd very much prefer to have a simple way to tell Dwarf versions from an
> instruction, but I don't have the bandwidth to do that now. Maybe Kristof
> can have a look at it.
>

It's not instruction based, in this case the choice of form is
definitely something that we need to conditionalize, just no one has
done the work for it yet.

-eric