[lld] r189718 - [lld][LinkingContext] Atoms created from command line options should be available in YAML

Rui Ueyama ruiu at google.com
Mon Sep 2 14:34:30 PDT 2013


> @@ -184,9 +184,7 @@ public:
>    // Set the entry symbol name. You may also need to call
> addDeadStripRoot() for
>    // the symbol if your platform supports dead-stripping, so that the
> symbol
>    // will not be removed from the output.
> -  void setEntrySymbolName(StringRef name) {
> -    // Entry function have to be resolved as an undefined symbol.
> -    addInitialUndefinedSymbol(name);
> +  virtual void setEntrySymbolName(StringRef name) {
>      _entrySymbolName = name;
>    }
>

You just removed addInitialUndefinedSymbol() and did not add the equivalent
code to anywhere, so entry symbol is not added to dead stripping root. As a
result the linker is now producing an incorrect output at least in -flavor
link mode. I'll resurrect this code as well as adding a test to find this
kind of breakage.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130902/02009e9c/attachment.html>


More information about the llvm-commits mailing list