[PATCH] Move generic isPrint and columnWidth implementations to a separate header/source to allow using both generic and system-dependent versions on win32.

Alexander Kornienko alexfh at google.com
Mon Sep 2 02:27:32 PDT 2013



================
Comment at: lib/Support/Locale.cpp:18
@@ +17,3 @@
+#if LLVM_ON_WIN32
+  return ' ' <= UCS && UCS <= '~';
+#else
----------------
Manuel Klimek wrote:
> I think this could need a comment. Why ~? I assume it's some limitations of a win32 terminal?
This is the range of non-control ASCII characters (0x20 - 0x7E). I can add this in a comment if you think it makes sense.


http://llvm-reviews.chandlerc.com/D1559



More information about the llvm-commits mailing list