[PATCH 2/2] Revert "CMake: don't install tablegen"

[Jordan Rose]

It makes sense to include llvm-tblgen in llvm-devel, just not the main llvm package. What do you think?

On Aug 30, 2013, at 12:08 , Johannes Obermayr <johannesobermayr at gmx.de> wrote:

> This is not possible because on OBS I first compile a llvm git master package and then a llvm-clang git master package which depends on llvm libLLVM and llvm-devel packages on build time.
> 
> So %_bindir/llvm-tablegen must be installed and included in llvm or llvm-devel package to get clang compiled.
> 
> But who cares about packaging on Linux distributions?
> 
> Am Freitag, 30. August 2013, 11:47:40 schrieb Reid Kleckner:
>> Please find a way to do this that doesn't install llvm-tblgen by default.
>> We don't actually want to distribute it to end users.
>> 
>> I believe we have some solution for supporting out-of-source builds using
>> llvm-config, but Hans or Jordan Rose (I think he uses CMake+XCode out of
>> source?) might know more.
>> 
>> 
>> On Fri, Aug 30, 2013 at 11:14 AM, Johannes Obermayr <johannesobermayr at gmx.de
>>> wrote:
>> 
>>> This reverts commit b7f81d372a884453f821a3764028771c4896c3be.
>>> SVN: r189130
>>> 
>>> Fixes (out-of-tree build):
>>> Scanning dependencies of target ClangCC1AsOptions
>>> make[2]: *** No rule to make target `/usr/bin/llvm-tblgen', needed by
>>> `include/clang/Driver/Options.inc.tmp'.  Stop.
>>> ---
>>> cmake/modules/TableGen.cmake | 2 ++
>>> 1 file changed, 2 insertions(+)
>>> 
>>> diff --git a/cmake/modules/TableGen.cmake b/cmake/modules/TableGen.cmake
>>> index d315a42..bf75ce2 100644
>>> --- a/cmake/modules/TableGen.cmake
>>> +++ b/cmake/modules/TableGen.cmake
>>> @@ -136,4 +136,6 @@ macro(add_tablegen target project)
>>>   if( LLVM_ENABLE_THREADS AND HAVE_LIBPTHREAD AND NOT BEOS )
>>>     target_link_libraries(${target} pthread)
>>>   endif()
>>> +
>>> +  install(TARGETS ${target} RUNTIME DESTINATION bin)
>>> endmacro()
>>> --
>>> 1.8.1.4
>>> 
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>