[PATCH] Add getUnrollingPreferences to TTI

Andrew Trick atrick at apple.com
Thu Aug 29 18:49:23 PDT 2013


On Aug 29, 2013, at 2:44 PM, Chandler Carruth <chandlerc at google.com> wrote:

> So, I'd like Andy to chime in on whether he's comfortable with this use of TTI. I think I'm OK with it, but it's a borderline case.

I don’t think this makes it harder to do the right thing later—move the whole partial unrolling pass after CGSCC. So OK for now.

> Second, I think essentially only the LoopVectorizer should use this to drive its partial unrolling. This is both because it has added information about when the cost is low (ILP) and when the cost is unusually high. Finally, it should happen at the same phase of the optimizer IMO (IE, it shouldn't drastically influence the behavior of the inliner). While the LoopVectorizer is currently inside the CGSCC pass pipeline, Nadav is working on moving it to live after that completes.

Yep…

-Andy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130829/a8fb9130/attachment.html>


More information about the llvm-commits mailing list