Sean Silva silvas at purdue.edu
Thu Aug 29 16:22:37 PDT 2013


Hi Matthias,

The LLVM community convention (also specified here: <
http://llvm.org/docs/DeveloperPolicy.html#making-a-patch>) is that patches
should be attached to the email to llvm-commits. Also, typically a batch of
small "obvious" patches should be individually attached to the same message
("Hi all, here are some small obvious fixes; please commit") rather than
each having their own message.

-- Sean Silva


On Thu, Aug 29, 2013 at 6:48 PM, <matze at braunis.de> wrote:

> From 02d89dcc988d30d6b07e999ebfde0a81592c0dcb Mon Sep 17 00:00:00 2001
> Message-Id: <
> 02d89dcc988d30d6b07e999ebfde0a81592c0dcb.1377816463.git.matze at braunis.de>
> From: Matthias Braun <matze at braunis.de>
> Date: Tue, 27 Aug 2013 13:13:51 -0700
> Subject: [PATCH 1/5] fix comment
> To: llvm-commits at cs.uiuc.edu
>
> There's no 'B3' in the example.
> ---
>  lib/CodeGen/RegisterCoalescer.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/CodeGen/RegisterCoalescer.cpp
> b/lib/CodeGen/RegisterCoalescer.cpp
> index 7c690cd..76a4630 100644
> --- a/lib/CodeGen/RegisterCoalescer.cpp
> +++ b/lib/CodeGen/RegisterCoalescer.cpp
> @@ -577,7 +577,7 @@ bool RegisterCoalescer::removeCopyByCommutingDef(const
> CoalescerPair &CP,
>    LiveInterval &IntB =
>      LIS->getInterval(CP.isFlipped() ? CP.getSrcReg() : CP.getDstReg());
>
> -  // BValNo is a value number in B that is defined by a copy from A. 'B3'
> in
> +  // BValNo is a value number in B that is defined by a copy from A. 'B1'
> in
>    // the example above.
>    VNInfo *BValNo = IntB.getVNInfoAt(CopyIdx);
>    if (!BValNo || BValNo->def != CopyIdx)
> --
> 1.8.3.4
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130829/66d2f742/attachment.html>


More information about the llvm-commits mailing list