[Debug Info PATCH] patches to generate unique identifier for external C++ types

[Eric Christopher]

One more comment on top of Dave's:

+  SmallVector<Value *, 4> RetainValues;
+  // Both createForwardDecl and createStruct|Class|etc|Type can add the same
+  // type to AllRetainTypes. A set is used to avoid duplication.
+  SmallPtrSet<Value *, 4> RetainSet;

4 seems a bit low.

-eric


On Thu, Aug 29, 2013 at 2:33 PM, Manman Ren <manman.ren at gmail.com> wrote:
> Hi,
>
> I think it is a good idea to start a new thread :)
> Attached please find 3 patches: one for llvm (update DIBuilder to retain
> types with unique
> identifier), one for clang (to generate the unique identifier), the last for
> updating testing cases.
>
> Thanks,
> Manman